[PR #9499/b45a7dab backport][3.11] Improve performance of creating the ConnectionKey #9500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit b45a7da)
bdraco
approved these changes
Oct 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #9500 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 106 106
Lines 35211 35211
Branches 4227 4227
=======================================
Hits 34455 34455
Misses 564 564
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.11/b45a7dab665e84a113bfbc6a261ef6e70d7887f8/pr-9499
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9499 as merged into master (b45a7da).
What do these changes do?
Improve performance of the client by reducing the overhead to create the
ConnectionKeyobjects.Reuses the same idea as aio-libs/yarl#1316 and aio-libs/yarl#1322
Calling
tuple.__new__is much faster because it avoids the extra runtime lambda having to be run and arguments unpacked for every message https://github.com/python/cpython/blob/d83fcf8371f2f33c7797bc8f5423a8bca8c46e5c/Lib/collections/__init__.py#L441This only works if the object being created is a
NamedTupleso this speed up is only recommended internally and should not be used outside ofaiohttpsince we do not guarantee that ConnectionKey will remain aNamedTuplein the future.Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no